Skip to content

ext/curl: Handle write callback return value conversion failures - #24269

Open
arshidkv12 wants to merge 3 commits into
php:masterfrom
arshidkv12:curl-php_curl_get_long
Open

arshidkv12 wants to merge 3 commits into
php:masterfrom
arshidkv12:curl-php_curl_get_long

Conversation

@arshidkv12

Copy link
Copy Markdown
Contributor

Handle conversion failures when converting the CURLOPT_WRITEFUNCTION callback return value to an integer, avoiding unintended conversion behavior.

@Sjord

Sjord commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Thanks, @arshidkv12.

It seems php_curl_get_long is used in multiple places, and returning -1 on error is not always the correct thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants